Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760852Ab3JPQLb (ORCPT ); Wed, 16 Oct 2013 12:11:31 -0400 Received: from mga09.intel.com ([134.134.136.24]:15119 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756018Ab3JPQL3 (ORCPT ); Wed, 16 Oct 2013 12:11:29 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,508,1378882800"; d="scan'208";a="393884461" Message-ID: <525EBBAA.9000209@linux.intel.com> Date: Wed, 16 Oct 2013 09:15:38 -0700 From: David Cohen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130929 Icedove/17.0.9 MIME-Version: 1.0 To: ohad@wizery.com CC: linux-kernel@vger.kernel.org, Jocelyn Falempe Subject: Re: [PATCH] rpmsg: reduce rpmsg_virtio verbosity References: <1380825415-20481-1-git-send-email-david.a.cohen@linux.intel.com> In-Reply-To: <1380825415-20481-1-git-send-email-david.a.cohen@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2201 Lines: 55 On 10/03/2013 11:36 AM, David Cohen wrote: > From: Jocelyn Falempe > > rpmsg_virtio TX/RX messages are very verbose, overflowing kernel printk > buffer. This patch makes the guilty print_hex_dump()'s to act as > dev_dbg() and do nothing in case neither DEBUG nor CONFIG_DYNAMIC_DEBUG > are defined. > > Signed-off-by: Jocelyn Falempe > Signed-off-by: David Cohen > --- Ping :) Comments here? Br, David Cohen > drivers/rpmsg/virtio_rpmsg_bus.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index b6135d4..e7c5927 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -749,8 +749,10 @@ int rpmsg_send_offchannel_raw(struct rpmsg_channel *rpdev, u32 src, u32 dst, > dev_dbg(dev, "TX From 0x%x, To 0x%x, Len %d, Flags %d, Reserved %d\n", > msg->src, msg->dst, msg->len, > msg->flags, msg->reserved); > - print_hex_dump(KERN_DEBUG, "rpmsg_virtio TX: ", DUMP_PREFIX_NONE, 16, 1, > +#if defined(CONFIG_DYNAMIC_DEBUG) || defined(DEBUG) > + print_hex_dump_debug("rpmsg_virtio TX: ", DUMP_PREFIX_NONE, 16, 1, > msg, sizeof(*msg) + msg->len, true); > +#endif > > sg_init_one(&sg, msg, sizeof(*msg) + len); > > @@ -786,8 +788,10 @@ static int rpmsg_recv_single(struct virtproc_info *vrp, struct device *dev, > dev_dbg(dev, "From: 0x%x, To: 0x%x, Len: %d, Flags: %d, Reserved: %d\n", > msg->src, msg->dst, msg->len, > msg->flags, msg->reserved); > - print_hex_dump(KERN_DEBUG, "rpmsg_virtio RX: ", DUMP_PREFIX_NONE, 16, 1, > +#if defined(CONFIG_DYNAMIC_DEBUG) || defined(DEBUG) > + print_hex_dump_debug("rpmsg_virtio RX: ", DUMP_PREFIX_NONE, 16, 1, > msg, sizeof(*msg) + msg->len, true); > +#endif > > /* > * We currently use fixed-sized buffers, so trivially sanitize > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/