Message-ID: <525EC929.5030001@zytor.com>
Date: Wed, 16 Oct 2013 10:13:13 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0
MIME-Version: 1.0
To: Jan Beulich <JBeulich@suse.com>
CC: mingo@elte.hu, tglx@linutronix.de,
        Linus Torvalds <torvalds@linux-foundation.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH, RFC] x86-64: properly handle FPU code/data selectors
References: <525E9BFF02000078000FB74E@nat28.tlf.novell.com> <525EB320.2000607@zytor.com> <525ED5F602000078000FB948@nat28.tlf.novell.com>
In-Reply-To: <525ED5F602000078000FB948@nat28.tlf.novell.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1249
Lines: 36

On 10/16/2013 09:07 AM, Jan Beulich wrote:
> 
>> Furthermore, you define X86_FEATURE_NO_FPU_SEL, but you don't set it
>> anywhere.  At least that bit needs to be factored out into a separate patch.
> 
> That's already being done in get_cpu_cap(), as it's part of
> x86_capability[9].
> 

Ah, sorry, my bad.  For some reason I thought you added it to word 3,
but this is a hardware-provided CPUID bit.  I, if anyone, should have
known :)

>> +	if (config_enabled(CONFIG_IA32_EMULATION) &&
>> +	    test_tsk_thread_flag(tsk, TIF_IA32))
>>
>> is_ia32_task()?
> 
> That'd imply that "tsk == current" in all cases, which I don't
> think is right here.

True.  It wold be good to have an equivalent predicate function for
another task, though.

This assumes the process doesn't switch modes on us, which it is allowed
to do.  For that it really would be better to look at the CS.L bit,
which can be done with the LAR instruction for the current task;
otherwise we'd have to walk the descriptor tables.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/