Date: Wed, 16 Oct 2013 11:06:27 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: Dhanunjaya <dhanunjaya.matrix@gmail.com>
Cc: eli.billauer@gmail.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: xillybus: fix for quoted string split
 across lines
Message-ID: <20131016180627.GA17116@kroah.com>
References: <1381946272-18651-1-git-send-email-dhanunjaya.matrix@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1381946272-18651-1-git-send-email-dhanunjaya.matrix@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1639
Lines: 48

On Wed, Oct 16, 2013 at 11:27:52PM +0530, Dhanunjaya wrote:
> This is a patch to the xillybus_of.c file that fixes up a
> quoted string split across lines warning found by the
> checkpatch.pl tool.
> 
> Signed-off-by: Dhanunjaya <dhanunjaya.matrix@gmail.com>

I need a full name here please.

> ---
>  drivers/staging/xillybus/xillybus_of.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/xillybus/xillybus_of.c b/drivers/staging/xillybus/xillybus_of.c
> index 92c2931..822ef4d 100644
> --- a/drivers/staging/xillybus/xillybus_of.c
> +++ b/drivers/staging/xillybus/xillybus_of.c
> @@ -117,8 +117,7 @@ static int xilly_drv_probe(struct platform_device *op)
>  
>  	rc = of_address_to_resource(dev->of_node, 0, &endpoint->res);
>  	if (rc) {
> -		pr_warn("xillybus: Failed to obtain device tree "
> -			"resource\n");
> +		pr_warn("xillybus: Failed to obtain device tree resource\n");

This should be using dev_warn() instead.

>  		goto failed_request_regions;
>  	}
>  
> @@ -141,8 +140,7 @@ static int xilly_drv_probe(struct platform_device *op)
>  	rc = request_irq(irq, xillybus_isr, 0, xillyname, endpoint);
>  
>  	if (rc) {
> -		pr_err("xillybus: Failed to register IRQ handler. "
> -		       "Aborting.\n");
> +		pr_err("xillybus: Failed to register IRQ handler, Aborting...\n");

dev_err() instead please here as well.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/