Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752994Ab3JQIO2 (ORCPT ); Thu, 17 Oct 2013 04:14:28 -0400 Received: from mail-ea0-f179.google.com ([209.85.215.179]:49346 "EHLO mail-ea0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752406Ab3JQIOY (ORCPT ); Thu, 17 Oct 2013 04:14:24 -0400 Date: Thu, 17 Oct 2013 10:14:20 +0200 From: Ingo Molnar To: Stephane Eranian Cc: Arnaldo Carvalho de Melo , Borislav Petkov , LKML , Peter Zijlstra , "mingo@elte.hu" , "ak@linux.intel.com" , Jiri Olsa , "Yan, Zheng" Subject: Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support Message-ID: <20131017081420.GB22705@gmail.com> References: <1381416608-2741-1-git-send-email-eranian@google.com> <20131010180049.GD9929@pd.tnic> <20131016124627.GA2611@gmail.com> <20131016175302.GB4100@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1659 Lines: 44 * Stephane Eranian wrote: > On Wed, Oct 16, 2013 at 7:53 PM, Arnaldo Carvalho de Melo > wrote: > > Em Wed, Oct 16, 2013 at 03:13:54PM +0200, Stephane Eranian escreveu: > >> On Wed, Oct 16, 2013 at 2:46 PM, Ingo Molnar wrote: > >> > We should also tell user-space that the unit of this counter is 'Joule'. > >> > > >> > Then things like: > >> > > >> > perf stat -a -e power/* sleep 1 > >> > > >> > would output, without knowing any RAPL details: > >> > > >> > 0.20619 Joule power/energy-core > >> > 2.42151 Joule power/energy-pkg > >> > > >> Not sure there is already some support for this in perf stat. Arnaldo? > > > > Nope, there is not, we would have to have some table somewhere with > > "event-regexp: unit-string" > > > >> If not that we need another sysfs file to export the unit. Another > >> possibility is for perf stat to recognize the power/* and extract the > >> unit from the event name. In my example power/joules-cores -> joules. > > > > I.e. you would be encoding the counter unit as the suffix, might as well > > call it "power/cores.joules" and use the dot as the separator for the > > unit, but would be just a compact form to encode the counter->unit > > table. > > May be easier to add a sysfs entry with the unit to display. Yes - with no entry meaning a raw 'count' or such. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/