Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754728Ab3JQKS2 (ORCPT ); Thu, 17 Oct 2013 06:18:28 -0400 Received: from mail.karo-electronics.de ([81.173.242.67]:59767 "EHLO mail.karo-electronics.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315Ab3JQKSZ convert rfc822-to-8bit (ORCPT ); Thu, 17 Oct 2013 06:18:25 -0400 Date: Thu, 17 Oct 2013 12:17:21 +0200 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Xiubo Li Cc: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec. Message-ID: <20131017121721.43e1b34b@ipc1.ka-ro> In-Reply-To: <1382000477-17304-6-git-send-email-Li.Xiubo@freescale.com> References: <1382000477-17304-1-git-send-email-Li.Xiubo@freescale.com> <1382000477-17304-6-git-send-email-Li.Xiubo@freescale.com> Organization: Ka-Ro electronics GmbH X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1690 Lines: 55 Hi, Xiubo Li wrote: > When the CONFIG_REGULATOR is disabled there will be some warnings > printed out. > > Signed-off-by: Xiubo Li > --- > sound/soc/codecs/sgtl5000.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c > index 1f4093f..4e2e4c9 100644 > --- a/sound/soc/codecs/sgtl5000.c > +++ b/sound/soc/codecs/sgtl5000.c > @@ -883,14 +883,19 @@ static int ldo_regulator_register(struct snd_soc_codec *codec, > struct regulator_init_data *init_data, > int voltage) > { > +#ifdef CONFIG_SND_SOC_FSL_SGTL5000 > + return 0; > +#else > dev_err(codec->dev, "this setup needs regulator support in the kernel\n"); > return -EINVAL; > +#endif > This looks wrong to me, as this will disable the error for unsolicited platforms in a multi arch kernel! > static int ldo_regulator_remove(struct snd_soc_codec *codec) > { > return 0; > } > + > #endif > Why do you add an extra empty line here? Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/