Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756818Ab3JQPxR (ORCPT ); Thu, 17 Oct 2013 11:53:17 -0400 Received: from mail-ea0-f170.google.com ([209.85.215.170]:37515 "EHLO mail-ea0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756289Ab3JQPxP (ORCPT ); Thu, 17 Oct 2013 11:53:15 -0400 Date: Thu, 17 Oct 2013 16:53:08 +0100 From: Lee Jones To: Jean-Christophe PLAGNIOL-VILLARD Cc: srinivas kandagatla , Maxime COQUELIN , Wolfram Sang , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Russell King , Grant Likely , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-i2c@vger.kernel.org" , Stuart MENEFY , Stephen GALLIMORE , Gabriel FERNANDEZ Subject: Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller Message-ID: <20131017155308.GQ19112@lee--X1> References: <1381754813-4679-1-git-send-email-maxime.coquelin@st.com> <1381754813-4679-2-git-send-email-maxime.coquelin@st.com> <20131016151419.GA14104@ns203013.ovh.net> <525F915D.9020501@st.com> <525FAEED.7030207@st.com> <20131017141957.GE14104@ns203013.ovh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20131017141957.GE14104@ns203013.ovh.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1860 Lines: 46 On Thu, 17 Oct 2013, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 10:33 Thu 17 Oct , srinivas kandagatla wrote: > > On 17/10/13 08:27, Maxime COQUELIN wrote: > > > ... > > >>> >> + > > >>> >> +static struct of_device_id st_i2c_match[] = { > > >>> >> + { .compatible = "st,comms-ssc-i2c", }, > > >> > the rules is to put the first soc that use the ip in the compatible > > >> > as st,sti7100-scc-i2c > > > Ok. There are no plans to upstream the SH4 platforms, it will only > > > remains in stlinux.com. > > > Maybe I can set the first ARM platform (STiH415)? > > > That would give st,stih415-ssc-i2c. > > NAK, for st,stih415-ssc-i2c naming. > > > > IMO, this makes sense when the same IP integration done on different SOC > > changes slightly/very differently. > > > > But in this case the "comms" IP remains unchanged across all the SOCs. > > > > I would still prefer "st,comms-ssc-i2c", allowing a single device driver > > to match against several SoCs. ST "comms" IP it is integrated across all > > the STi series of SoCs, so we don't want to add new entry in compatible > > for every new SOC. > > you never need this you always the first SoC that's all > > see other bindings on at91 as example sorry NACK I'm guessing that using the first SoC is an I2C'isum. Guys, if you don't want to be too specific, just make it as generic as possible whilest still using the SoC as a POR: st,stih41x-ssc-i2c will do for now, as it covers all current bases. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/