Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757809Ab3JQQI3 (ORCPT ); Thu, 17 Oct 2013 12:08:29 -0400 Received: from nat28.tlf.novell.com ([130.57.49.28]:52683 "EHLO nat28.tlf.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756863Ab3JQQI2 convert rfc822-to-8bit (ORCPT ); Thu, 17 Oct 2013 12:08:28 -0400 Message-Id: <5260279702000078000FBDE8@nat28.tlf.novell.com> X-Mailer: Novell GroupWise Internet Agent 12.0.2 Date: Thu, 17 Oct 2013 17:08:23 +0100 From: "Jan Beulich" To: "Arjan van de Ven" Cc: , , , , Subject: Re: [PATCH] x86: unify copy_from_user() checking References: <525E964402000078000FB70C@nat28.tlf.novell.com> <525E9BF7.7020706@linux.intel.com> <525EC6C402000078000FB895@nat28.tlf.novell.com> <525EC73E.3060204@linux.intel.com> <525FCDD702000078000FBBF5@nat28.tlf.novell.com> <52600608.2010704@linux.intel.com> <5260241602000078000FBDD9@nat28.tlf.novell.com> <52600A99.2070507@linux.intel.com> In-Reply-To: <52600A99.2070507@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 732 Lines: 21 >>> On 17.10.13 at 18:04, Arjan van de Ven wrote: >> >> ... and the non-constant case be taken care of at run time. >> That's precisely what the patch does. > > fair enough. > > I would like to see a comment above the code to describe this reasoning > and the objective and what the desired behavior is... so that we don't > have to reverse engineer this again 2 years from now ;-) Will do, and then perhaps mirror the whole behavior to copy_to_user(). Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/