Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759313Ab3JQSft (ORCPT ); Thu, 17 Oct 2013 14:35:49 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:57290 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758539Ab3JQSfs (ORCPT ); Thu, 17 Oct 2013 14:35:48 -0400 MIME-Version: 1.0 In-Reply-To: References: <1381961482-25085-1-git-send-email-geyslan@gmail.com> Date: Thu, 17 Oct 2013 15:35:46 -0300 Message-ID: Subject: Re: [Kernel-BR] Re: [PATCH] sound: pci: emu10k1: code refactoring and casting removal From: Raphael S Carvalho To: kernel-br@googlegroups.com, =?ISO-8859-1?Q?Geyslan_Greg=F3rio_Bem?= Cc: Takashi Iwai , Jaroslav Kysela , Bill Pemberton , "moderated list:SOUND" , open list Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1257 Lines: 31 > 2013/10/17 Takashi Iwai : >> >> Geyslan, you don't have to waste too much of your time (and my time >> for review) for this kind of so old driver code unless it really fixes >> the bugs. A clean up is good in general, but it can be sometimes >> worse than nothing since it also breaks the history, thus makes hard >> to follow via "git blame", for example, and of course, there is always >> a potential danger of regression. >> >> So, if it's about clean up, do it only in a systematic way that others >> can follow easily, and don't do it too intensively. >> >> >> thanks, >> >> Takashi His code refactoring proposal is welcome since the old code sucks from several points of view, e.g. maintainability, legibility, etc. Yes, of course, it's important to be careful in order not to introduce regressions. And yes, he could improve something here and there. As long as changes improve the maintainability and legibility of the code, there is no reason to refuse them. -- Raphael S. Carvalho -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/