Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762588Ab3JQVzl (ORCPT ); Thu, 17 Oct 2013 17:55:41 -0400 Received: from mga09.intel.com ([134.134.136.24]:43631 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762890Ab3JQVwI (ORCPT ); Thu, 17 Oct 2013 17:52:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,517,1378882800"; d="scan'208";a="394625555" From: David Cohen To: x86@kernel.org, hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de Cc: linux-kernel@vger.kernel.org, Fengguang Wu , Kuppuswamy Sathyanarayanan , "H. Peter Anvin" Subject: [PATCH v9 05/14] intel_mid: fix coccinelle warnings Date: Thu, 17 Oct 2013 14:55:48 -0700 Message-Id: <1382046957-15987-6-git-send-email-david.a.cohen@linux.intel.com> X-Mailer: git-send-email 1.8.4.rc3 In-Reply-To: <1382046957-15987-1-git-send-email-david.a.cohen@linux.intel.com> References: <1382046957-15987-1-git-send-email-david.a.cohen@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1548 Lines: 43 From: Fengguang Wu arch/x86/pci/intel_mid_pci.c:153:9-10: WARNING: return of 0/1 in function 'type1_access_ok' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: coccinelle/misc/boolreturn.cocci CC: Kuppuswamy Sathyanarayanan CC: H. Peter Anvin Signed-off-by: Fengguang Wu --- arch/x86/pci/intel_mid_pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c index f8715f7..c5ca5b9 100644 --- a/arch/x86/pci/intel_mid_pci.c +++ b/arch/x86/pci/intel_mid_pci.c @@ -150,12 +150,12 @@ static bool type1_access_ok(unsigned int bus, unsigned int devfn, int reg) * shim. Therefore, use the header type in shim instead. */ if (reg >= 0x100 || reg == PCI_STATUS || reg == PCI_HEADER_TYPE) - return 0; + return false; if (bus == 0 && (devfn == PCI_DEVFN(2, 0) || devfn == PCI_DEVFN(0, 0) || devfn == PCI_DEVFN(3, 0))) - return 1; - return 0; /* Langwell on others */ + return true; + return false; /* Langwell on others */ } static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, -- 1.8.4.rc3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/