Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753663Ab3JRNDz (ORCPT ); Fri, 18 Oct 2013 09:03:55 -0400 Received: from top.free-electrons.com ([176.31.233.9]:56329 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751684Ab3JRNDy (ORCPT ); Fri, 18 Oct 2013 09:03:54 -0400 Message-ID: <526131B8.5030207@free-electrons.com> Date: Fri, 18 Oct 2013 15:03:52 +0200 From: Michael Opdenacker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Geert Uytterhoeven CC: Andrew Morton , "linux-kernel@vger.kernel.org" , Linux Embedded , janne.karhunen@gmail.com Subject: Re: [PATCH v2] init: make init failures more explicit References: <1382097633-10166-1-git-send-email-michael.opdenacker@free-electrons.com> In-Reply-To: X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 924 Lines: 25 On 10/18/2013 02:20 PM, Geert Uytterhoeven wrote: > On Fri, Oct 18, 2013 at 2:00 PM, Michael Opdenacker > wrote: >> + pr_err("Starting init: %s exists but couldn't execute it (error: %d - see errno-base.h and errno.h)\n", > IMHO the "- see errno-base.h and errno.h" is a bit overkill. Yes, I was wondering. Good to have your opinion on this! I'll post an update with just the error number, also adding the error code to the other two "Failed to execute" error messages. Thanks! Michael. -- Michael Opdenacker, CEO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com +33 484 258 098 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/