Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754881Ab3JROXg (ORCPT ); Fri, 18 Oct 2013 10:23:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52653 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754378Ab3JROXd (ORCPT ); Fri, 18 Oct 2013 10:23:33 -0400 From: Mike Snitzer To: Jens Axboe Cc: linux-kernel@vger.kernel.org, dm-devel@redhat.com, l.flis@cyfronet.pl Subject: [PATCH] block: properly stack underlying max_segment_size to DM device Date: Fri, 18 Oct 2013 10:23:26 -0400 Message-Id: <1382106206-4459-1-git-send-email-snitzer@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1324 Lines: 42 Without this patch all DM devices will default to BLK_MAX_SEGMENT_SIZE (65536) even if the underlying device(s) have a larger value -- this is due to blk_stack_limits() using min_not_zero() when stacking the max_segment_size limit. # cat /sys/block/sda/queue/max_segment_size 1073741824 # cat /sys/block/dm-0/queue/max_segment_size before patch: 65536 after patch: 1073741824 Reported-by: Lukasz Flis Signed-off-by: Mike Snitzer Cc: stable@vger.kernel.org # v3.3+ --- block/blk-settings.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/block/blk-settings.c b/block/blk-settings.c index c50ecf0..29f28bb 100644 --- a/block/blk-settings.c +++ b/block/blk-settings.c @@ -143,6 +143,7 @@ void blk_set_stacking_limits(struct queue_limits *lim) /* Inherit limits from component devices */ lim->discard_zeroes_data = 1; lim->max_segments = USHRT_MAX; + lim->max_segment_size = UINT_MAX; lim->max_hw_sectors = UINT_MAX; lim->max_sectors = UINT_MAX; lim->max_write_same_sectors = UINT_MAX; -- 1.7.4.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/