Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756441Ab3JRPnI (ORCPT ); Fri, 18 Oct 2013 11:43:08 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:41394 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755764Ab3JRPnG (ORCPT ); Fri, 18 Oct 2013 11:43:06 -0400 Date: Fri, 18 Oct 2013 16:42:46 +0100 From: Russell King - ARM Linux To: Stefano Stabellini Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, konrad.wilk@oracle.com, Ian.Campbell@citrix.com, will.deacon@arm.com Subject: Re: [PATCH v8 08/19] arm/xen: get_dma_ops: return xen_dma_ops if we are running as xen_initial_domain Message-ID: <20131018154246.GB25034@n2100.arm.linux.org.uk> References: <1382031814-8782-8-git-send-email-stefano.stabellini@eu.citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1110 Lines: 39 On Fri, Oct 18, 2013 at 01:22:18PM +0100, Stefano Stabellini wrote: > Russell, > are you OK with this patch? Only concern is why the change is soo large. > > -static inline struct dma_map_ops *get_dma_ops(struct device *dev) > > +static inline struct dma_map_ops *__generic_dma_ops(struct device *dev) > > { > > if (dev && dev->archdata.dma_ops) > > return dev->archdata.dma_ops; > > return &arm_dma_ops; > > } > > > > +static inline struct dma_map_ops *get_dma_ops(struct device *dev) > > +{ > > + if (xen_initial_domain()) > > + return xen_dma_ops; > > + else > > + return __generic_dma_ops(dev); > > +} > > + What's wrong with: static inline struct dma_map_ops *get_dma_ops(struct device *dev) { + if (xen_initial_domain()) + return xen_dma_ops; if (dev && dev->archdata.dma_ops) return dev->archdata.dma_ops; return &arm_dma_ops; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/