Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756495Ab3JRUJq (ORCPT ); Fri, 18 Oct 2013 16:09:46 -0400 Received: from mail-vb0-f52.google.com ([209.85.212.52]:61677 "EHLO mail-vb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756206Ab3JRUJ3 (ORCPT ); Fri, 18 Oct 2013 16:09:29 -0400 MIME-Version: 1.0 In-Reply-To: <52610493.1000909@samsung.com> References: <1381876762-10892-1-git-send-email-dianders@chromium.org> <1381876762-10892-3-git-send-email-dianders@chromium.org> <525E611A.6070708@imgtec.com> <52610493.1000909@samsung.com> Date: Fri, 18 Oct 2013 13:09:28 -0700 X-Google-Sender-Auth: juFStmU7bDTQvIMjDQbj4hp57WE Message-ID: Subject: Re: [PATCH 2/2] mmc: dw_mmc: Protect read-modify-write of INTMASK with a lock From: Doug Anderson To: Jaehoon Chung Cc: James Hogan , Chris Ball , Seungwon Jeon , Grant Grundler , Alim Akhtar , Abhilash Kesavan , Tomasz Figa , Olof Johansson , Sonny Rao , Bing Zhao , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 800 Lines: 17 Jaehoon / James On Fri, Oct 18, 2013 at 2:51 AM, Jaehoon Chung wrote: >> In this case it'd only be a space and code complexity thing I think. I >> suppose in some cases the benefit of finer-grained locking is probably >> pretty marginal, but there's a good case for it here. It might be >> worth renaming the lock to irq_lock or something like that so it's >> clear it doesn't have to protect only for INTMASK in the future - up >> to you. > It seems good that use the irq_lock than intmask_lock. (It's just naming) Done in v2. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/