Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754885Ab3JSBgD (ORCPT ); Fri, 18 Oct 2013 21:36:03 -0400 Received: from mail-oa0-f47.google.com ([209.85.219.47]:53132 "EHLO mail-oa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754602Ab3JSBgB (ORCPT ); Fri, 18 Oct 2013 21:36:01 -0400 Message-ID: <5261E1FE.2030304@lwfinger.net> Date: Fri, 18 Oct 2013 20:35:58 -0500 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Felipe Pena , Chaoming Li , "John W. Linville" CC: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtlwifi: rtl8192se: Fix wrong assignment References: <1382143960-4594-1-git-send-email-felipensp@gmail.com> In-Reply-To: <1382143960-4594-1-git-send-email-felipensp@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1433 Lines: 40 On 10/18/2013 07:52 PM, Felipe Pena wrote: > There is a typo in the struct member name on assignment when checking > rtlphy->current_chan_bw == HT_CHANNEL_WIDTH_20_40, the check uses pwrgroup_ht40 > for bound limit and uses pwrgroup_ht20 when assigning instead. > > Signed-off-by: Felipe Pena > --- > drivers/net/wireless/rtlwifi/rtl8192se/rf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/rf.c b/drivers/net/wireless/rtlwifi/rtl8192se/rf.c > index 5061f1d..92d38ab 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8192se/rf.c > +++ b/drivers/net/wireless/rtlwifi/rtl8192se/rf.c > @@ -265,7 +265,7 @@ static void _rtl92s_get_txpower_writeval_byregulatory(struct ieee80211_hw *hw, > rtlefuse->pwrgroup_ht40 > [RF90_PATH_A][chnl - 1]) { > pwrdiff_limit[i] = > - rtlefuse->pwrgroup_ht20 > + rtlefuse->pwrgroup_ht40 > [RF90_PATH_A][chnl - 1]; > } > } else { > -- Acked-by: Larry Finger John: I forgot to mention this earlier, but when you add your s-o-b, please add a Cc for Stable [3.0 +]. Thanks, Larry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/