Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753563Ab3JSRJZ (ORCPT ); Sat, 19 Oct 2013 13:09:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39614 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752120Ab3JSRJY (ORCPT ); Sat, 19 Oct 2013 13:09:24 -0400 Date: Sat, 19 Oct 2013 19:02:14 +0200 From: Oleg Nesterov To: David Long Cc: linux-arm-kernel@lists.infradead.org, Rabin Vincent , "Jon Medhurst (Tixy)" , Srikar Dronamraju , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 02/13] uprobes: allow ignoring of probe hits Message-ID: <20131019170214.GA8324@redhat.com> References: <1381871068-27660-1-git-send-email-dave.long@linaro.org> <1381871068-27660-3-git-send-email-dave.long@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381871068-27660-3-git-send-email-dave.long@linaro.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 608 Lines: 21 On 10/15, David Long wrote: > > @@ -1732,9 +1732,6 @@ static void handle_swbp(struct pt_regs *regs) > return; > } > > - /* change it in advance for ->handler() and restart */ > - instruction_pointer_set(regs, bp_vaddr); > - Well, this looks obviously wrong. This SET_IP() has the comment ;) Note also that with this breaks __skip_sstep() on x86. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/