Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753666Ab3JSRgm (ORCPT ); Sat, 19 Oct 2013 13:36:42 -0400 Received: from mail-qe0-f44.google.com ([209.85.128.44]:53067 "EHLO mail-qe0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753381Ab3JSRgl convert rfc822-to-8bit (ORCPT ); Sat, 19 Oct 2013 13:36:41 -0400 References: In-Reply-To: Mime-Version: 1.0 (1.0) Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset=utf-8 Message-Id: Cc: Neil Horman , "David S. Miller" , "linux-sctp@vger.kernel.org" , "netdev@vger.kernel.org" , LKML X-Mailer: iPad Mail (10B329) From: Vlad Yasevich Subject: Re: net: sctp: possible dereference after freeing Date: Sat, 19 Oct 2013 13:36:35 -0400 To: =?utf-8?Q?Geyslan_Greg=C3=B3rio_Bem?= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1461 Lines: 53 On Oct 19, 2013, at 7:49 AM, Geyslan Gregório Bem wrote: > 2013/10/19 Geyslan Gregório Bem : >> Hi maintainers, >> >> I would like to know if these are catches: >> >> /net/sctp/endpointola.c (281) >> static void sctp_endpoint_destroy(struct sctp_endpoint *ep) >> { >> struct sock *sk; >> ... >> kfree(ep); >> SCTP_DBG_OBJCNT_DEC(ep); >> } >> >> The 'ep' object counter is being decremented?! Is the kfree to be there indeed? >> Let me know what was intended here. >> >> Same here: >> /net/sctp/endpointola.c (165) >> static void sctp_transport_destroy_rcu(struct rcu_head *head) >> { >> struct sctp_transport *transport; >> ... >> kfree(transport); >> SCTP_DBG_OBJCNT_DEC(transport); >> } >> >> Regards, >> >> Geyslan Gregório Bem >> hackingbits.com > > Oops. I got it. ;) > > extern atomic_t sctp_dbg_objcnt_ep; > http://lxr.free-electrons.com/source/include/net/sctp/sctp.h#L269 > extern atomic_t sctp_dbg_objcnt_transport; > http://lxr.free-electrons.com/source/arch/x86/include/asm/atomic.h#L105 > > Cheers. There is no reference here since the macro turns variable name to string using ## name. So the order doesn't matter really. -vlad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/