Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752986Ab3JUIfv (ORCPT ); Mon, 21 Oct 2013 04:35:51 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:53341 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752963Ab3JUIfu convert rfc822-to-8bit (ORCPT ); Mon, 21 Oct 2013 04:35:50 -0400 MIME-Version: 1.0 In-Reply-To: <20130906093800.GF32654@lee--X1> References: <1378454473-24508-1-git-send-email-sachin.kamat@linaro.org> <20130906093800.GF32654@lee--X1> Date: Mon, 21 Oct 2013 14:05:50 +0530 Message-ID: Subject: Re: [PATCH v3 1/4] ab8500-charger: Check return value of regulator_enable From: Sachin Kamat Cc: LKML , anton@enomsg.org, David Woodhouse Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1154 Lines: 39 On 6 September 2013 15:08, Lee Jones wrote: > On Fri, 06 Sep 2013, Sachin Kamat wrote: > >> Check the return value of regulator_enable to silence the following >> type of warnings: >> drivers/power/ab8500_charger.c:1390:20: warning: ignoring return value >> of ?regulator_enable?, declared with attribute warn_unused_result >> [-Wunused-result] >> >> Signed-off-by: Sachin Kamat >> Cc: Lee Jones >> --- >> Compile tested. >> >> Changes since v2: >> * removed redundant assignment to false. >> Changes since v1: >> * converted dev_err and return to dev_warn as suggested by Lee Jones. >> --- >> >> drivers/power/ab8500_charger.c | 16 ++++++++++++---- >> 1 file changed, 12 insertions(+), 4 deletions(-) > > Looks good now. > > Acked-by: Lee Jones > Ping on this series, Anton.. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/