Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 25 Oct 2002 15:06:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 25 Oct 2002 15:06:06 -0400 Received: from noodles.codemonkey.org.uk ([213.152.47.19]:664 "EHLO noodles.internal") by vger.kernel.org with ESMTP id ; Fri, 25 Oct 2002 15:06:02 -0400 Date: Fri, 25 Oct 2002 20:13:56 +0100 From: Dave Jones To: Robert Love Cc: linux-kernel@vger.kernel.org, "Nakajima, Jun" , chrisl@vmware.com, "Martin J. Bligh" Subject: Re: [PATCH] How to get number of physical CPU in linux from user space? Message-ID: <20021025191356.GA11189@suse.de> Mail-Followup-To: Dave Jones , Robert Love , linux-kernel@vger.kernel.org, "Nakajima, Jun" , chrisl@vmware.com, "Martin J. Bligh" References: <1035572950.1501.3429.camel@phantasy> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1035572950.1501.3429.camel@phantasy> User-Agent: Mutt/1.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 654 Lines: 18 On Fri, Oct 25, 2002 at 03:09:09PM -0400, Robert Love wrote: > +#ifdef CONFIG_SMP > + seq_printf(m, "physical processor ID\t: %d\n", phys_proc_id[n]); > + seq_printf(m, "number of siblings\t: %d\n", smp_num_siblings); > +#endif Should this be wrapped in a if (cpu_has_ht(c)) { } ? Seems silly to be displaying HT information on non-HT CPUs. Dave -- | Dave Jones. http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/