Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752830Ab3JUP40 (ORCPT ); Mon, 21 Oct 2013 11:56:26 -0400 Received: from mail-pb0-f48.google.com ([209.85.160.48]:42862 "EHLO mail-pb0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752729Ab3JUP4Z (ORCPT ); Mon, 21 Oct 2013 11:56:25 -0400 Message-ID: <52654EA6.6020805@gmail.com> Date: Mon, 21 Oct 2013 08:56:22 -0700 From: Dirk Brandewie User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: "Geyslan G. Bem" , kernel-br@googlegroups.com CC: "Rafael J. Wysocki" , Viresh Kumar , "open list:CPU FREQUENCY DRI..." , "open list:CPU FREQUENCY DRI..." , open list Subject: Re: [PATCH] cpufreq: intel_pstate: fix possible integer overflow References: <1382239876-12688-1-git-send-email-geyslan@gmail.com> In-Reply-To: <1382239876-12688-1-git-send-email-geyslan@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1102 Lines: 30 On 10/19/2013 08:31 PM, Geyslan G. Bem wrote: > The expression 'pstate << 8' is evaluated using 32-bit arithmetic while > 'val' expects an expression of type u64. > > Signed-off-by: Geyslan G. Bem Acked-by: Dirk Brandewie > --- > drivers/cpufreq/intel_pstate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index badf620..43446b5 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -395,7 +395,7 @@ static void intel_pstate_set_pstate(struct cpudata *cpu, int pstate) > trace_cpu_frequency(pstate * 100000, cpu->cpu); > > cpu->pstate.current_pstate = pstate; > - val = pstate << 8; > + val = (u64)pstate << 8; > if (limits.no_turbo) > val |= (u64)1 << 32; > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/