Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751950Ab3JUR76 (ORCPT ); Mon, 21 Oct 2013 13:59:58 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:49197 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751463Ab3JUR74 (ORCPT ); Mon, 21 Oct 2013 13:59:56 -0400 MIME-Version: 1.0 Reply-To: mceier+kernel@gmail.com In-Reply-To: <52656971.3020509@ti.com> References: <5265640C.4070201@cogentembedded.com> <1382377504-24688-1-git-send-email-mceier+kernel@gmail.com> <52656971.3020509@ti.com> Date: Mon, 21 Oct 2013 19:59:54 +0200 X-Google-Sender-Auth: IDwoo3k7hdAR6OpfSozVSckoV3U Message-ID: Subject: Re: [PATCH] davinci_emac.c: Fix IFF_ALLMULTI setup From: Mariusz Ceier To: Mugunthan V N Cc: "David S. Miller" , Lad Prabhakar , Jingoo Han , Jiri Pirko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1312 Lines: 35 Yes of course ;) This was my first patch for the kernel. I will remember about v2 tag next time. Thanks, Mariusz Ceier On 21 October 2013 19:50, Mugunthan V N wrote: > On Monday 21 October 2013 11:15 PM, Mariusz Ceier wrote: >> When IFF_ALLMULTI flag is set on interface and IFF_PROMISC isn't, >> emac_dev_mcast_set should only enable RX of multicasts and reset >> MACHASH registers. >> >> It does this, but afterwards it either sets up multicast MACs >> filtering or disables RX of multicasts and resets MACHASH registers >> again, rendering IFF_ALLMULTI flag useless. >> >> This patch fixes emac_dev_mcast_set, so that multicast MACs filtering and >> disabling of RX of multicasts are skipped when IFF_ALLMULTI flag is set. >> >> Tested with kernel 2.6.37. >> >> Signed-off-by: Mariusz Ceier >> --- > Can you add [PATCH v2] in your subject in future so that it will be > easier to the maintainer to pick the latest version of the patch. > > Acked-by: Mugunthan V N > > Regards > Mugunthan V N -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/