Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753181Ab3JVCfD (ORCPT ); Mon, 21 Oct 2013 22:35:03 -0400 Received: from mail-wg0-f47.google.com ([74.125.82.47]:40049 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752776Ab3JVCfA (ORCPT ); Mon, 21 Oct 2013 22:35:00 -0400 MIME-Version: 1.0 In-Reply-To: <1382377504-24688-1-git-send-email-mceier+kernel@gmail.com> References: <5265640C.4070201@cogentembedded.com> <1382377504-24688-1-git-send-email-mceier+kernel@gmail.com> From: Prabhakar Lad Date: Tue, 22 Oct 2013 08:04:39 +0530 Message-ID: Subject: Re: [PATCH] davinci_emac.c: Fix IFF_ALLMULTI setup To: Mariusz Ceier Cc: "David S. Miller" , Mugunthan V N , Jingoo Han , Jiri Pirko , netdev , LKML Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 26 Hi Mariusz, On Mon, Oct 21, 2013 at 11:15 PM, Mariusz Ceier wrote: > When IFF_ALLMULTI flag is set on interface and IFF_PROMISC isn't, > emac_dev_mcast_set should only enable RX of multicasts and reset > MACHASH registers. > > It does this, but afterwards it either sets up multicast MACs > filtering or disables RX of multicasts and resets MACHASH registers > again, rendering IFF_ALLMULTI flag useless. > > This patch fixes emac_dev_mcast_set, so that multicast MACs filtering and > disabling of RX of multicasts are skipped when IFF_ALLMULTI flag is set. > > Tested with kernel 2.6.37. > It would have been better if you would have tested this on the latest kernel. Anyway David has pulled this patch in his tree. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/