Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753561Ab3JVGSw (ORCPT ); Tue, 22 Oct 2013 02:18:52 -0400 Received: from mga09.intel.com ([134.134.136.24]:18072 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751166Ab3JVGSu (ORCPT ); Tue, 22 Oct 2013 02:18:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,535,1378882800"; d="scan'208";a="422733213" Date: Tue, 22 Oct 2013 14:15:40 +0800 From: Haicheng Li To: Gu Zheng Cc: Gao feng , Kim , f2fs , fsdevel , linux-kernel Subject: Re: [PATCH] f2fs: introduce f2fs_kmem_cache_alloc to hide the unfailed kmem cache allocation Message-ID: <20131022061540.GL21006@hli22-desktop> References: <5264D6C7.9000202@cn.fujitsu.com> <5265F5E6.3000604@cn.fujitsu.com> <20131022051636.GJ21006@hli22-desktop> <52660E62.9090409@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52660E62.9090409@cn.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2274 Lines: 72 On Tue, Oct 22, 2013 at 01:34:26PM +0800, Gu Zheng wrote: > On 10/22/2013 01:16 PM, Haicheng Li wrote: > > > On Tue, Oct 22, 2013 at 11:49:58AM +0800, Gao feng wrote: > >> On 10/21/2013 03:24 PM, Gu Zheng wrote: > >>> +static inline void *f2fs_kmem_cache_alloc(struct kmem_cache *cachep, > >>> + gfp_t flags) > >>> +{ > >>> + void *entry = kmem_cache_alloc(cachep, flags); > >>> +retry: > >> > >> retry after kmem_cache_alloc? > > > > Good catch. > > > > Sorry for the carelessness in my previous review. > > Besides this, I also found another issue as below: > > > >> On Mon, Oct 21, 2013 at 03:24:55PM +0800, Gu Zheng wrote: > >>> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > >>> index ef80f79..fe3cf8e 100644 > >>> --- a/fs/f2fs/node.c > >>> +++ b/fs/f2fs/node.c > >>> @@ -1308,11 +1308,7 @@ static int add_free_nid(struct f2fs_nm_info *nm_i, nid_t nid, bool build) > >>> if (allocated) > >>> return 0; > >>> retry: > > -retry? > > Can be removed here, this tag still used by front goto jumping. But it > seems that we need to use another suitable name rather than "retry". how about like this? --- diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index fe3cf8e..4fa3fd5 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1296,18 +1296,17 @@ static int add_free_nid(struct f2fs_nm_info *nm_i, nid_t nid, bool build) if (nid == 0) return 0; - if (!build) - goto retry; + if (build) { + /* do not add allocated nids */ + read_lock(&nm_i->nat_tree_lock); + ne = __lookup_nat_cache(nm_i, nid); + if (ne && nat_get_blkaddr(ne) != NULL_ADDR) + allocated = true; + read_unlock(&nm_i->nat_tree_lock); + if (allocated) + return 0; + } - /* do not add allocated nids */ - read_lock(&nm_i->nat_tree_lock); - ne = __lookup_nat_cache(nm_i, nid); - if (ne && nat_get_blkaddr(ne) != NULL_ADDR) - allocated = true; - read_unlock(&nm_i->nat_tree_lock); - if (allocated) - return 0; -retry: i = f2fs_kmem_cache_alloc(free_nid_slab, GFP_NOFS); i->nid = nid; i->state = NID_NEW; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/