Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753154Ab3JVGcx (ORCPT ); Tue, 22 Oct 2013 02:32:53 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:23544 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751196Ab3JVGcw (ORCPT ); Tue, 22 Oct 2013 02:32:52 -0400 X-IronPort-AV: E=Sophos;i="4.93,546,1378828800"; d="scan'208";a="8824572" Message-ID: <52661AB2.8050501@cn.fujitsu.com> Date: Tue, 22 Oct 2013 14:26:58 +0800 From: Gu Zheng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: Haicheng Li CC: Gao feng , Kim , f2fs , fsdevel , linux-kernel Subject: Re: [PATCH] f2fs: introduce f2fs_kmem_cache_alloc to hide the unfailed kmem cache allocation References: <5264D6C7.9000202@cn.fujitsu.com> <5265F5E6.3000604@cn.fujitsu.com> <20131022051636.GJ21006@hli22-desktop> <52660E62.9090409@cn.fujitsu.com> <20131022061540.GL21006@hli22-desktop> In-Reply-To: <20131022061540.GL21006@hli22-desktop> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/10/22 14:30:14, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/10/22 14:30:18, Serialize complete at 2013/10/22 14:30:18 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2461 Lines: 83 On 10/22/2013 02:15 PM, Haicheng Li wrote: > On Tue, Oct 22, 2013 at 01:34:26PM +0800, Gu Zheng wrote: >> On 10/22/2013 01:16 PM, Haicheng Li wrote: >> >>> On Tue, Oct 22, 2013 at 11:49:58AM +0800, Gao feng wrote: >>>> On 10/21/2013 03:24 PM, Gu Zheng wrote: >>>>> +static inline void *f2fs_kmem_cache_alloc(struct kmem_cache *cachep, >>>>> + gfp_t flags) >>>>> +{ >>>>> + void *entry = kmem_cache_alloc(cachep, flags); >>>>> +retry: >>>> >>>> retry after kmem_cache_alloc? >>> >>> Good catch. >>> >>> Sorry for the carelessness in my previous review. >>> Besides this, I also found another issue as below: >>> >>>> On Mon, Oct 21, 2013 at 03:24:55PM +0800, Gu Zheng wrote: >>>>> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c >>>>> index ef80f79..fe3cf8e 100644 >>>>> --- a/fs/f2fs/node.c >>>>> +++ b/fs/f2fs/node.c >>>>> @@ -1308,11 +1308,7 @@ static int add_free_nid(struct f2fs_nm_info *nm_i, nid_t nid, bool build) >>>>> if (allocated) >>>>> return 0; >>>>> retry: >>> -retry? >> >> Can be removed here, this tag still used by front goto jumping. But it >> seems that we need to use another suitable name rather than "retry". > > how about like this? > --- > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index fe3cf8e..4fa3fd5 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -1296,18 +1296,17 @@ static int add_free_nid(struct f2fs_nm_info *nm_i, nid_t nid, bool build) > if (nid == 0) > return 0; > > - if (!build) > - goto retry; > + if (build) { > + /* do not add allocated nids */ > + read_lock(&nm_i->nat_tree_lock); > + ne = __lookup_nat_cache(nm_i, nid); > + if (ne && nat_get_blkaddr(ne) != NULL_ADDR) > + allocated = true; > + read_unlock(&nm_i->nat_tree_lock); > + if (allocated) > + return 0; > + } Good, it's more neat, I'll take this, thanks.:) Regards, Gu > > - /* do not add allocated nids */ > - read_lock(&nm_i->nat_tree_lock); > - ne = __lookup_nat_cache(nm_i, nid); > - if (ne && nat_get_blkaddr(ne) != NULL_ADDR) > - allocated = true; > - read_unlock(&nm_i->nat_tree_lock); > - if (allocated) > - return 0; > -retry: > i = f2fs_kmem_cache_alloc(free_nid_slab, GFP_NOFS); > i->nid = nid; > i->state = NID_NEW; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/