Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752863Ab3JVKUZ (ORCPT ); Tue, 22 Oct 2013 06:20:25 -0400 Received: from nasmtp02.atmel.com ([204.2.163.16]:45722 "EHLO SJOEDG01.corp.atmel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751438Ab3JVKUX (ORCPT ); Tue, 22 Oct 2013 06:20:23 -0400 X-Greylist: delayed 308 seconds by postgrey-1.27 at vger.kernel.org; Tue, 22 Oct 2013 06:20:23 EDT Message-ID: <52664FB6.4000004@atmel.com> Date: Tue, 22 Oct 2013 18:13:10 +0800 From: Bo Shen User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Thierry Reding , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell CC: , , , , , , Subject: Re: [PATCH v5] PWM: atmel-pwm: add PWM controller driver References: <1380532240-18650-1-git-send-email-voice.shen@atmel.com> <20131008131727.GB12839@ulmo.nvidia.com> In-Reply-To: <20131008131727.GB12839@ulmo.nvidia.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.168.5.13] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1754 Lines: 48 Hi All, On 10/8/2013 21:17, Thierry Reding wrote: > On Mon, Sep 30, 2013 at 05:10:40PM +0800, Bo Shen wrote: >> Add Atmel PWM controller driver based on PWM framework. >> >> This is the basic function implementation of Atmel PWM controller. >> It can work with PWM based led and backlight. >> >> Signed-off-by: Bo Shen >> >> --- >> Changes in v5: >> - call clk_disable directly, if so, it won't cause more than one channel >> enabled, the clock can not be disabled. >> >> Changes in v4: >> - check the return value of clk_prepare() >> - change channel register size as constant >> >> Changes in v3: >> - change compatible string from "atmel,sama5-pwm" to "atmel,sama5d3-pwm" >> - Add PWM led example in binding documentation >> - Using micro replace hard code >> >> Changes in v2: >> - Address the comments from Thierry Reding >> >> .../devicetree/bindings/pwm/atmel-pwm.txt | 41 +++ >> drivers/pwm/Kconfig | 9 + >> drivers/pwm/Makefile | 1 + >> drivers/pwm/pwm-atmel.c | 344 ++++++++++++++++++++ >> 4 files changed, 395 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pwm/atmel-pwm.txt >> create mode 100644 drivers/pwm/pwm-atmel.c > > I haven't seen an Acked-by from the device tree bindings maintainers on > this. I've Cc'ed them, so hopefully one of them has time to review. Any comments? Best Regards, Bo Shen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/