Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752545Ab3JVMHQ (ORCPT ); Tue, 22 Oct 2013 08:07:16 -0400 Received: from ringil.hengli.com.au ([178.18.16.133]:33279 "EHLO fornost.hengli.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751372Ab3JVMHO (ORCPT ); Tue, 22 Oct 2013 08:07:14 -0400 Date: Tue, 22 Oct 2013 20:07:04 +0800 From: Herbert Xu To: Dmitry Kasatkin Cc: Mimi Zohar , linux-security-module@vger.kernel.org, Dmitry Kasatkin , "linux-kernel@vger.kernel.org" , James Morris , David Howells Subject: Re: [PATCH v2 01/23] crypto: provide single place for hash algo information Message-ID: <20131022120704.GA9375@gondor.apana.org.au> References: <1382395388-8108-1-git-send-email-zohar@linux.vnet.ibm.com> <1382395388-8108-2-git-send-email-zohar@linux.vnet.ibm.com> <20131022052458.GA5896@gondor.apana.org.au> <20131022113203.GA8965@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1595 Lines: 40 On Tue, Oct 22, 2013 at 12:57:02PM +0100, Dmitry Kasatkin wrote: > On Tue, Oct 22, 2013 at 12:32 PM, Herbert Xu > wrote: > > On Tue, Oct 22, 2013 at 12:29:56PM +0100, Dmitry Kasatkin wrote: > >> > >> We are not adding user-space interface. > >> We just need to algo definitions which are in sync between user space, > >> IMA/EVM and kernel module signing. > >> Module signing perl script uses hard coded values. We want to improve > >> it export them to user space. > >> > >> But please give us a hint, what crypto user-space API helps for us? > > > > OK, if you're not exporting the kernel asymmetric key code then > > that's fine. > > Can we take this to mean acked-by you? FWIW I'm against introducing new interfaces using integer IDs for crypto algorithms. Especially if such an interface is exposed to user-space. You said that you're not currently using this as a kernel/user-space interface, which I can live with grudgingly. However, the fact that you've placed this file in uapi leads me to believe that at some future point in time there will be some sort of kernel/user-space interface using this. Why else would they need to be in sync? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/