Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753483Ab3JVOdE (ORCPT ); Tue, 22 Oct 2013 10:33:04 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:36379 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752696Ab3JVOc5 (ORCPT ); Tue, 22 Oct 2013 10:32:57 -0400 Date: Tue, 22 Oct 2013 15:32:43 +0100 From: Mark Rutland To: "Ivan T. Ivanov" Cc: Stanimir Varbanov , "balbi@ti.com" , "rob.herring@calxeda.com" , Pawel Moll , "swarren@wwwdotorg.org" , "ian.campbell@citrix.com" , "rob@landley.net" , "gregkh@linuxfoundation.org" , "grant.likely@linaro.org" , "idos@codeaurora.org" , "mgautam@codeaurora.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" Subject: Re: [PATCH v6 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DW PHY's Message-ID: <20131022143242.GA4691@kartoffel> References: <1381131897-13910-1-git-send-email-iivanov@mm-sol.com> <1381131897-13910-3-git-send-email-iivanov@mm-sol.com> <52527D38.1070505@mm-sol.com> <1381246952.24031.83.camel@iivanov-dev.int.mm-sol.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1381246952.24031.83.camel@iivanov-dev.int.mm-sol.com> Thread-Topic: [PATCH v6 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DW PHY's Accept-Language: en-GB, en-US Content-Language: en-US User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1044 Lines: 27 [...] > > > + phy->sleep_a_clk = devm_clk_get(phy->dev, "sleep_a"); > > > > What means the "_a" in clock name? > > They are 2 PHY's on 8074 chip. This drivers is supposed to > operate on PHY 0, thus sleep_a. PHY 1 is using sleep_b. Take a look > here http://www.spinics.net/lists/arm-kernel/msg276945.html When you say two PHYs, do you mean the HS PHY and the SS PHY? Or are there two HS PHYs? If so, would the other HS PHY have a sleep_b clock? The clock-names property should describe the clocks from the view of the device itself. As we're describing the PHY in isolation, rather than a big block that contains the PHY, the presesnce or absence of other PHYs should not affect the name. If the "_a" suffix is only to differentiate the instance of PHY, it should be dropped. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/