Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754752Ab3JVQ5d (ORCPT ); Tue, 22 Oct 2013 12:57:33 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:45205 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754178Ab3JVQ5a (ORCPT ); Tue, 22 Oct 2013 12:57:30 -0400 MIME-Version: 1.0 In-Reply-To: <1382446896-28436-2-git-send-email-sre@debian.org> References: <1382446896-28436-1-git-send-email-sre@debian.org> <1382446896-28436-2-git-send-email-sre@debian.org> Date: Tue, 22 Oct 2013 18:57:29 +0200 Message-ID: Subject: Re: [PATCH 1/2] leds: lp55xx: handle enable pin in driver From: Linus Walleij To: Sebastian Reichel Cc: Sebastian Reichel , =?ISO-8859-1?Q?Beno=EEt_Cousson?= , Tony Lindgren , Bryan Wu , Richard Purdie , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Russell King , Rob Landley , Milo Kim , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-leds@vger.kernel.org" , Linux-OMAP Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 24 On Tue, Oct 22, 2013 at 3:01 PM, Sebastian Reichel wrote: > This patch moves the handling of the chip's enable pin from the board > code into the driver. It also updates all board-code files using the > driver to incorporate this change. > > This is needed for device tree support of the enable pin. > > Signed-off-by: Sebastian Reichel Looks good to me. Acked-by: Linus Walleij BTW: should we disable the GPIO when remove()ing the module? This is a topic of another patch but... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/