Date: Tue, 22 Oct 2013 14:38:39 -0400 (EDT)
Message-Id: <20131022.143839.2085832416728125724.davem@davemloft.net>
To: sebastian@breakpoint.cc
Cc: andi@firstfloor.org, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org, ak@linux.intel.com,
        netdev@vger.kernel.org
Subject: Re: [PATCH] net: wan: sbni: remove assembly crc32 code
From: David Miller <davem@davemloft.net>
In-Reply-To: <20131022183625.GA4382@breakpoint.cc>
References: <1382458346-24811-12-git-send-email-andi@firstfloor.org>
	<20131022.135928.2040131908206663695.davem@davemloft.net>
	<20131022183625.GA4382@breakpoint.cc>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 910
Lines: 26

From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Date: Tue, 22 Oct 2013 20:36:25 +0200

> 
> There is also a C function doing the same thing. Unless the asm code is
> 110% faster we could stick to the C function.
> 
> Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
> ---
> 
> On Tue, Oct 22, 2013 at 01:59:28PM -0400, David Miller wrote:
>> 
>> Is it really impossible to use the generic crc32 support instead of this
>> unsightly custom inline assembler?
> 
> Since you asked for this here step 1.

If it's that simple, this is definitely what we should do.

On the off chance, is there anyone actually able to test this
change? :-)))
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/