Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754710Ab3JVUss (ORCPT ); Tue, 22 Oct 2013 16:48:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44519 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753966Ab3JVUsr (ORCPT ); Tue, 22 Oct 2013 16:48:47 -0400 Date: Wed, 23 Oct 2013 07:48:01 +1100 From: Dave Chinner To: John Stultz Cc: LKML , Greg KH , Colin Cross , Android Kernel Team , Glauber Costa Subject: Re: [PATCH] staging: ashmem: Fix ASHMEM_PURGE_ALL_CACHES return value Message-ID: <20131022204801.GC1969@devil.localdomain> References: <1382374687-4831-1-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1382374687-4831-1-git-send-email-john.stultz@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 720 Lines: 22 On Mon, Oct 21, 2013 at 09:58:07AM -0700, John Stultz wrote: > Hopefully this isn't too late for 3.12. > > In commit 7dc19d5aff (convert shrinkers to new count/scan API) > the return value to PURGE_ALL_CACHES was dropped, causing -EPERM > to always be returned. > > This patch re-adds the ret assignment, setting it to the the > ashmem_shrink_count(), which is the lru_count. Looks sane. Acked-by: Dave Chinner -- Dave Chinner dchinner@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/