Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755167Ab3JWBeA (ORCPT ); Tue, 22 Oct 2013 21:34:00 -0400 Received: from ozlabs.org ([203.10.76.45]:40100 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753655Ab3JWBd6 (ORCPT ); Tue, 22 Oct 2013 21:33:58 -0400 From: Rusty Russell To: Andi Kleen , x86@kernel.org Cc: linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 2/7] x86, asmlinkage, lguest: Fix C functions used by inline assembler In-Reply-To: <1382458079-24450-3-git-send-email-andi@firstfloor.org> References: <1382458079-24450-1-git-send-email-andi@firstfloor.org> <1382458079-24450-3-git-send-email-andi@firstfloor.org> User-Agent: Notmuch/0.15.2 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Wed, 23 Oct 2013 10:56:36 +1030 Message-ID: <87txg8j0hv.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2337 Lines: 70 Andi Kleen writes: > From: Andi Kleen > > - Make the C code used by the paravirt stubs visible > - Since they have to be global now, give them a more unique > name. > > Cc: rusty@rustcorp.com.au > Cc: x86@kernel.org > Signed-off-by: Andi Kleen Acked-by: Rusty Russell Cheers, Rusty. > --- > arch/x86/lguest/boot.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c > index bdf8532..ad1fb5f 100644 > --- a/arch/x86/lguest/boot.c > +++ b/arch/x86/lguest/boot.c > @@ -233,13 +233,13 @@ static void lguest_end_context_switch(struct task_struct *next) > * flags word contains all kind of stuff, but in practice Linux only cares > * about the interrupt flag. Our "save_flags()" just returns that. > */ > -static unsigned long save_fl(void) > +asmlinkage unsigned long lguest_save_fl(void) > { > return lguest_data.irq_enabled; > } > > /* Interrupts go off... */ > -static void irq_disable(void) > +asmlinkage void lguest_irq_disable(void) > { > lguest_data.irq_enabled = 0; > } > @@ -253,8 +253,8 @@ static void irq_disable(void) > * PV_CALLEE_SAVE_REGS_THUNK(), which pushes %eax onto the stack, calls the > * C function, then restores it. > */ > -PV_CALLEE_SAVE_REGS_THUNK(save_fl); > -PV_CALLEE_SAVE_REGS_THUNK(irq_disable); > +PV_CALLEE_SAVE_REGS_THUNK(lguest_save_fl); > +PV_CALLEE_SAVE_REGS_THUNK(lguest_irq_disable); > /*:*/ > > /* These are in i386_head.S */ > @@ -1291,9 +1291,9 @@ __init void lguest_init(void) > */ > > /* Interrupt-related operations */ > - pv_irq_ops.save_fl = PV_CALLEE_SAVE(save_fl); > + pv_irq_ops.save_fl = PV_CALLEE_SAVE(lguest_save_fl); > pv_irq_ops.restore_fl = __PV_IS_CALLEE_SAVE(lg_restore_fl); > - pv_irq_ops.irq_disable = PV_CALLEE_SAVE(irq_disable); > + pv_irq_ops.irq_disable = PV_CALLEE_SAVE(lguest_irq_disable); > pv_irq_ops.irq_enable = __PV_IS_CALLEE_SAVE(lg_irq_enable); > pv_irq_ops.safe_halt = lguest_safe_halt; > > -- > 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/