Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755621Ab3JWCQl (ORCPT ); Tue, 22 Oct 2013 22:16:41 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:42575 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755207Ab3JWCQi (ORCPT ); Tue, 22 Oct 2013 22:16:38 -0400 MIME-Version: 1.0 In-Reply-To: <20131023020955.GF29695@two.firstfloor.org> References: <1382458346-24811-1-git-send-email-andi@firstfloor.org> <1382458346-24811-12-git-send-email-andi@firstfloor.org> <20131022.135928.2040131908206663695.davem@davemloft.net> <20131023020955.GF29695@two.firstfloor.org> From: Florian Fainelli Date: Tue, 22 Oct 2013 19:15:57 -0700 Message-ID: Subject: Re: [PATCH 11/11] asmlinkage, wan/sbni: Make inline assembler symbols visible and assembler global To: Andi Kleen Cc: David Miller , Andrew Morton , "linux-kernel@vger.kernel.org" , ak@linux.intel.com, netdev Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1394 Lines: 41 2013/10/22 Andi Kleen : > On Tue, Oct 22, 2013 at 01:59:28PM -0400, David Miller wrote: >> From: Andi Kleen >> Date: Tue, 22 Oct 2013 09:12:26 -0700 >> >> > From: Andi Kleen >> > >> > - Inline assembler defining C callable code has to be global >> > - The function has to be visible >> > >> > Do this in wan/sbni >> > >> > Cc: netdev@vger.kernel.org >> > Signed-off-by: Andi Kleen >> >> Is it really impossible to use the generic crc32 support instead of this >> unsightly custom inline assembler? > > Yes it's impossible. > > There's no way for me to test it, and this would be a far too big change > to submit untested. > > Also my only interest here is this thing not breaking my LTO > allyesconfig build. I'm not even sure what it does. > > Just because some legacy driver breaks my build you cannot make me > accountable for maintaining it now. > > If it's not possible to get this trivial change in I would need > to mark it "depends on !LTO" in Kconfig. How about scheduling the WAN drivers for removal? Does anybody actually use them nowadays? -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/