Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751426Ab3JWF4G (ORCPT ); Wed, 23 Oct 2013 01:56:06 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:51374 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751163Ab3JWF4D (ORCPT ); Wed, 23 Oct 2013 01:56:03 -0400 Message-ID: <526764EA.9000002@gmail.com> Date: Wed, 23 Oct 2013 06:55:54 +0100 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Adrian Hunter , Arnaldo Carvalho de Melo CC: Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, Frederic Weisbecker , Jiri Olsa , Mike Galbraith , Namhyung Kim , Paul Mackerras , Stephane Eranian Subject: Re: [PATCH V2 03/14] perf script: Make perf_script a local variable References: <1382427258-17495-1-git-send-email-adrian.hunter@intel.com> <1382427258-17495-4-git-send-email-adrian.hunter@intel.com> In-Reply-To: <1382427258-17495-4-git-send-email-adrian.hunter@intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1063 Lines: 34 On 10/22/13 8:34 AM, Adrian Hunter wrote: > -static int __cmd_script(struct perf_session *session) > +static int __cmd_script(struct perf_script *scr) for naming consistency that should be *script. > { > int ret; > > signal(SIGINT, sig_handler); > > - ret = perf_session__process_events(session, &perf_script); > + ret = perf_session__process_events(scr->session, &scr->tool); > > if (debug_mode) > pr_err("Misordered timestamps: %" PRIu64 "\n", nr_unordered); > @@ -1273,6 +1264,21 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused) > char *script_path = NULL; > const char **__argv; > int i, j, err; > + struct perf_script perf_script = { Ditto: struct perf_script script; Otherwise the change looks fine to me. Acked-by: David Ahern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/