Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752430Ab3JWIpW (ORCPT ); Wed, 23 Oct 2013 04:45:22 -0400 Received: from mail-oa0-f45.google.com ([209.85.219.45]:37940 "EHLO mail-oa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752394Ab3JWIpS (ORCPT ); Wed, 23 Oct 2013 04:45:18 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 23 Oct 2013 10:45:18 +0200 Message-ID: Subject: Re: [PATCH -next] pinctrl: tb10x: fix the error handling in tb10x_pinctrl_probe() From: Linus Walleij To: Wei Yongjun Cc: Grant Likely , Rob Herring , Wei Yongjun , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 936 Lines: 26 On Mon, Oct 21, 2013 at 4:55 AM, Wei Yongjun wrote: > From: Wei Yongjun > > This patch fix the error handling in tb10x_pinctrl_probe(): > - devm_ioremap_resource() return ERR_PTR() and never return NULL > - remove the dev_err call to avoid redundant error message > - pinctrl_register() returns NULL not ERR_PTR() > > Signed-off-by: Wei Yongjun Thanks, patch applied! Hm this seems to be an easy mistake to do. I have discussed in the past whether we can make the compiler verify error pointers semantically and warn on problems. I don't know if that is achieveable though :-( Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/