Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754263Ab3JXJX2 (ORCPT ); Thu, 24 Oct 2013 05:23:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48941 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752036Ab3JXJX1 (ORCPT ); Thu, 24 Oct 2013 05:23:27 -0400 Date: Thu, 24 Oct 2013 11:26:21 +0200 Message-ID: From: Takashi Iwai To: Joe Perches Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela , alsa-devel@alsa-project.org Subject: Re: [PATCH 8/8] sound: Remove OOM message after input_allocate_device In-Reply-To: <67fa483a408bf2abe0e2fad829f3c496130ae507.1382555436.git.joe@perches.com> References: <67fa483a408bf2abe0e2fad829f3c496130ae507.1382555436.git.joe@perches.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1165 Lines: 41 At Wed, 23 Oct 2013 12:14:54 -0700, Joe Perches wrote: > > Emitting an OOM message isn't necessary after input_allocate_device > as there's a generic OOM and a dump_stack already done. > > Signed-off-by: Joe Perches Thanks, applied. Takashi > --- > sound/pci/hda/hda_beep.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/sound/pci/hda/hda_beep.c b/sound/pci/hda/hda_beep.c > index 63c9909..20d065a 100644 > --- a/sound/pci/hda/hda_beep.c > +++ b/sound/pci/hda/hda_beep.c > @@ -151,10 +151,8 @@ static int snd_hda_do_attach(struct hda_beep *beep) > int err; > > input_dev = input_allocate_device(); > - if (!input_dev) { > - printk(KERN_INFO "hda_beep: unable to allocate input device\n"); > + if (!input_dev) > return -ENOMEM; > - } > > /* setup digital beep device */ > input_dev->name = "HDA Digital PCBeep"; > -- > 1.8.1.2.459.gbcd45b4.dirty > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/