Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754616Ab3JXKaO (ORCPT ); Thu, 24 Oct 2013 06:30:14 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52303 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753177Ab3JXKaM (ORCPT ); Thu, 24 Oct 2013 06:30:12 -0400 Message-ID: <1382610609.1559.12.camel@linux-fkkt.site> Subject: Re: [PATCH v2] Input: add regulator haptic driver From: Oliver Neukum To: "hyunhee.kim" Cc: "'Dmitry Torokhov'" , broonie@opensource.wolfsonmicro.com, peter.ujfalusi@ti.com, wfp5p@virginia.edu, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, kyungmin.park@samsung.com, "'Aristeu Sergio Rozanski Filho'" Date: Thu, 24 Oct 2013 12:30:09 +0200 In-Reply-To: <028401ced09b$1f6564d0$5e302e70$%kim@samsung.com> References: <000a01cec629$3cf34de0$b6d9e9a0$%kim@samsung.com> <20131021155558.GA4255@core.coreip.homeip.net> <025101ced083$35f2a270$a1d7e750$%kim@samsung.com> <1382603886.1559.11.camel@linux-fkkt.site> <028401ced09b$1f6564d0$5e302e70$%kim@samsung.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.9.4 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 629 Lines: 20 On Thu, 2013-10-24 at 18:26 +0900, hyunhee.kim wrote: > Hi, > > Thanks for your review. > I resent patch v3 after removing wrong wrapping. > > I made one toggle function because enable/disable functions have redundant codes and another reviewer suggested it. > Is it better to separate it into two functions? Linus doesn't like parameters affecting behavior. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/