Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754906Ab3JXLvk (ORCPT ); Thu, 24 Oct 2013 07:51:40 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:60755 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754749Ab3JXLvj (ORCPT ); Thu, 24 Oct 2013 07:51:39 -0400 MIME-Version: 1.0 In-Reply-To: <5269032E.2060400@asianux.com> References: <5267AE7D.4080600@asianux.com> <52688C42.3030907@asianux.com> <5269032E.2060400@asianux.com> Date: Thu, 24 Oct 2013 13:51:38 +0200 X-Google-Sender-Auth: FrBaGMcYo6JfjdnpxC9aGn6Axlc Message-ID: Subject: Re: [PATCH] arc: kernel: add default extern variable 'screen_info' in "setup.c" From: Geert Uytterhoeven To: Chen Gang Cc: Vineet Gupta , Arnd Bergmann , "sachin.kamat@linaro.org" , Paul Gortmaker , James Hogan , "linux-kernel@vger.kernel.org" , Will Deacon , Catalin Marinas Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2562 Lines: 58 Hi Chen, On Thu, Oct 24, 2013 at 1:23 PM, Chen Gang wrote: >> Lot's of negative dependencies are missing for VGA_CONSOLE. >> I think only alpha, some arm, ia64, some mips, some powerpc, and x86 >> may use it. >> > > in "arch" sub-directory, contents 13/30 (43.3%) architectures contents > VGA_CONSOLE. > > 1 alpha/kernel/setup.c:137:struct screen_info screen_info = { > 2 arm/kernel/setup.c:743:struct screen_info screen_info = { > 3 cris/kernel/setup.c:28:struct screen_info screen_info; > 4 ia64/kernel/setup.c:79:struct screen_info screen_info; > 5 m32r/kernel/setup.c:55:struct screen_info screen_info = { > 6 mips/kernel/setup.c:43:struct screen_info screen_info; > 7 powerpc/kernel/setup-common.c:88:struct screen_info screen_info = { > 8 score/kernel/setup.c:37:struct screen_info screen_info; > 9 sh/kernel/setup.c:68:struct screen_info screen_info; > 10 sparc/kernel/setup_64.c:66:struct screen_info screen_info = { > 11 sparc/kernel/setup_32.c:53:struct screen_info screen_info = { > 12 tile/kernel/setup.c:54:struct screen_info screen_info; > 13 x86/kernel/setup.c:220:struct screen_info screen_info; > 14 xtensa/kernel/setup.c:55:struct screen_info screen_info = { 0, 24, 0, 0, 0, 80, 0, 0, 0, 24, 1, 16}; > > It seems most of pc and servers support VGA_CONSOLE. I'm quite sure many of these just provide a screen_info to make vgacon compile. >> Compare this to a shiny new feature that available on all new architectures, >> but not on a few old one. There it makes sense to have the negative >> dependencies on the old architectures, that will never have the new feature. >> While new architectures have enabled it by default. >> > > Excuse me, my English is not quite well, I do not quite understand your > meaning, but it seems not quite important for our discussing, so I just > skip it, now. Sorry, I should stop writing complex sentences. For now, nevermind. There aren't that many real cases like this. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/