Date: Thu, 24 Oct 2013 14:36:51 -0200
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Felipe Pena <felipensp@gmail.com>
Cc: Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
        Matthew Garrett <matthew.garrett@nebula.com>,
        ibm-acpi-devel@lists.sourceforge.net,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thinkpad-acpi: Fix wrong assignment
Message-ID: <20131024163651.GB3851@khazad-dum.debian.net>
References: <1382136067-3888-1-git-send-email-felipensp@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1382136067-3888-1-git-send-email-felipensp@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 920
Lines: 24

On Fri, 18 Oct 2013, Felipe Pena wrote:
> In the thermal_init function when checking for thinkpad_id.ec_model,
> the 'ta2' variable is being OR'd when acpi_ec_read call succeeds,
> on fail it is setting 0 to 'ta1' variable instead.
> 
> Signed-off-by: Felipe Pena <felipensp@gmail.com>

NAK.

ta1 == 0 implies malfunction on the direct-from-EC temperature reading,
which is what the code wants to signal.  The code is correct as is.

Do not merge this patch.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/