Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755670Ab3JXRdO (ORCPT ); Thu, 24 Oct 2013 13:33:14 -0400 Received: from mga11.intel.com ([192.55.52.93]:57190 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755304Ab3JXRdM (ORCPT ); Thu, 24 Oct 2013 13:33:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,563,1378882800"; d="scan'208";a="422214184" Date: Thu, 24 Oct 2013 22:08:29 +0530 From: Vinod Koul To: Joel Fernandes , dmaengine@vger.kernel.org Cc: Matt Porter , Mark Brown , Russell King , Dan Williams , Jyri Sarha , Lars Peter-Clausen , Linux OMAP List , Linux ARM Kernel List , Linux DaVinci Kernel List , Linux Kernel Mailing List , alsa-devel@alsa-project.org Subject: Re: [PATCH 2/3] dma: edma: Add support for Cyclic DMA Message-ID: <20131024163829.GA21230@intel.com> References: <1379977515-3794-1-git-send-email-joelf@ti.com> <1379977515-3794-3-git-send-email-joelf@ti.com> <20131021065319.GM14013@intel.com> <52669A23.2080805@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52669A23.2080805@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 983 Lines: 26 On Tue, Oct 22, 2013 at 10:30:43AM -0500, Joel Fernandes wrote: > On 10/21/2013 01:53 AM, Vinod Koul wrote: > > On Mon, Sep 23, 2013 at 06:05:14PM -0500, Joel Fernandes wrote: > >> + nr_periods = (buf_len / period_len) + 1; > > ? > > > > consider the case of buf = period_len, above makes nr_period = 2. > > > > Or buf len 100, period len 50, makes nr_period = 3 > > > > Both doesnt seem right to me? > > I guess that variable name is misleading. > > nr_periods is actually the total no.of slots needed to process the request. Its > value is 1 greater than the total number of periods. Okay sounds good to me. I tried applying below but looks like it fails as I have already applied, 1 & 3. Can you pls rebase this resend -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/