Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756054Ab3JXShP (ORCPT ); Thu, 24 Oct 2013 14:37:15 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:40916 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754747Ab3JXShN (ORCPT ); Thu, 24 Oct 2013 14:37:13 -0400 Date: Thu, 24 Oct 2013 11:37:08 -0700 From: Dmitry Torokhov To: Joe Perches Cc: linux-kernel@vger.kernel.org, Wan ZongShun , Andrey Moiseev , Henrik Rydberg , Josh Wu , Ferruh Yigit , Pau Oliva Fora , Ben Dooks , Kukjin Kim , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device Message-ID: <20131024183707.GA5281@core.coreip.homeip.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 811 Lines: 23 Hi Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: > Emitting an OOM message isn't necessary after input_allocate_device > as there's a generic OOM and a dump_stack already done. No, please don't. The kzalloc may get changed in the future to not dump stack (that was added originally because not everyone was handling OOM properly, right?), input core might get changed to use something else than kzalloc, etc, etc. The majority of errors use dev_err so we also get idea what device failed (if there are several), and more. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/