Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755773Ab3JXUgt (ORCPT ); Thu, 24 Oct 2013 16:36:49 -0400 Received: from mail-pb0-f49.google.com ([209.85.160.49]:52960 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754936Ab3JXUgs (ORCPT ); Thu, 24 Oct 2013 16:36:48 -0400 MIME-Version: 1.0 X-Originating-IP: [67.83.170.180] In-Reply-To: <20131024201349.GG4998@ghostprotocols.net> References: <1382583069-26121-1-git-send-email-patrick@parcs.ath.cx> <20131024201349.GG4998@ghostprotocols.net> Date: Thu, 24 Oct 2013 16:36:47 -0400 Message-ID: Subject: Re: [PATCH] perf: Fix library detection when building without libelf From: Patrick Palka To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Paul Mackerras , Ingo Molnar , Jiri Olsa Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1602 Lines: 39 On Thu, Oct 24, 2013 at 4:13 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 23, 2013 at 10:51:09PM -0400, Patrick Palka escreveu: >> When I attempt to build perf on a system with slang but without libelf, >> 'make' would wrongly complain that the slang library could not be found. >> >> It turns out that this was happening because we are not filtering -lelf >> from EXTLIBS early enough. As a result, the library test for slang >> (ditto for gtk, libaudit, etc) erroneously passes -lelf to try-cc, which >> of course fails on a system without libelf. >> >> This patch makes the filtering of -lelf from EXTLIBS occur right after >> testing for libelf support, so that the subsequent library tests will >> not erroneously pass -lelf to try-cc when building without libelf >> support. > > Can you please check with the perf/core branch in my tree or Ingo's? > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core > > or Ingo's: > > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core > > The feature detection was reworked and perhaps it is fixed there. > > - Arnaldo I can't reproduce the detection failure in your branch, and a quick inspection shows that the new feature-detection code is not subject to the kind of bug that my patch fixed. So consider my patch obsolete. Thanks, Patrick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/