Date: Fri, 25 Oct 2013 12:45:33 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, hch@infradead.org,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 01/11] Export __smp_call_function_single()
Message-ID: <20131025104533.GA4373@gmail.com>
References: <1382606764-8309-1-git-send-email-axboe@kernel.dk>
 <1382606764-8309-2-git-send-email-axboe@kernel.dk>
 <20131025102154.GB3481@gmail.com>
 <20131025104435.GC6285@kernel.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131025104435.GC6285@kernel.dk>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1226
Lines: 43


* Jens Axboe <axboe@kernel.dk> wrote:

> On Fri, Oct 25 2013, Ingo Molnar wrote:
> > 
> > * Jens Axboe <axboe@kernel.dk> wrote:
> > 
> > > The blk-mq core and the blk-mq null driver uses it.
> > > 
> > > Cc: Ingo Molnar <mingo@kernel.org>
> > > Signed-off-by: Jens Axboe <axboe@kernel.dk>
> > > ---
> > >  kernel/smp.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/kernel/smp.c b/kernel/smp.c
> > > index 0564571..9de461e 100644
> > > --- a/kernel/smp.c
> > > +++ b/kernel/smp.c
> > > @@ -340,6 +340,7 @@ void __smp_call_function_single(int cpu, struct call_single_data *csd,
> > >  	}
> > >  	put_cpu();
> > >  }
> > > +EXPORT_SYMBOL(__smp_call_function_single);
> > 
> > I agree with exporting it to in-kernel users, but I'd prefer a _GPL 
> > export for newly exported symbols that are for in-kernel use.
> 
> Agree, it should be _GPL. I will update the patch. Can I add your
> acked-by?

Sure:

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/