Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751604Ab3JYLOi (ORCPT ); Fri, 25 Oct 2013 07:14:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22561 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168Ab3JYLOh (ORCPT ); Fri, 25 Oct 2013 07:14:37 -0400 Date: Fri, 25 Oct 2013 13:13:39 +0200 From: Jiri Olsa To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com, acme@redhat.com, zheng.z.yan@intel.com, bp@alien8.de Subject: Re: [PATCH v3 3/4] perf,x86: add Intel RAPL PMU support Message-ID: <20131025111339.GA1219@krava.redhat.com> References: <1382533085-7166-1-git-send-email-eranian@google.com> <1382533085-7166-4-git-send-email-eranian@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1382533085-7166-4-git-send-email-eranian@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 733 Lines: 26 On Wed, Oct 23, 2013 at 02:58:04PM +0200, Stephane Eranian wrote: SNIP > + > + perf_cpu_notifier(rapl_cpu_notifier); > + > + ret = perf_pmu_register(&rapl_pmu_class, "power", -1); > + WARN_ON(ret); > + if (!ret) { > + pr_info("RAPL PMU detected, registration failed, RAPL PMU disabled\n"); > + put_online_cpus(); > + return -1; > + } should above rather be: if (WARN_ON(ret)) { pr_info("RAPL PMU detected, registration failed, RAPL PMU disabled\n"); jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/