Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753968Ab3JYOJc (ORCPT ); Fri, 25 Oct 2013 10:09:32 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:51548 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752480Ab3JYOJ3 (ORCPT ); Fri, 25 Oct 2013 10:09:29 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: Linus Torvalds , Knut Petersen , Ingo Molnar , Thomas Gleixner , Paul McKenney , =?ISO-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , Greg Kroah-Hartman , Greg KH , linux-kernel , "cpufreq@vger.kernel.org" , Linux PM list Subject: Re: [BUG 3.12.rc4] Oops: unable to handle kernel paging request during shutdown Date: Fri, 25 Oct 2013 16:21:31 +0200 Message-ID: <1396106.vGULxZgqeb@vostro.rjw.lan> User-Agent: KMail/4.10.5 (Linux/3.12.0-rc6+; KDE/4.10.5; x86_64; ; ) In-Reply-To: References: <525BD08C.2080101@t-online.de> <1529148.xq0P7G6L83@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1464 Lines: 44 On Friday, October 25, 2013 07:19:57 PM Viresh Kumar wrote: > On 25 October 2013 16:40, Rafael J. Wysocki wrote: > > --- > > drivers/cpufreq/acpi-cpufreq.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > Index: linux-pm/drivers/cpufreq/acpi-cpufreq.c > > =================================================================== > > --- linux-pm.orig/drivers/cpufreq/acpi-cpufreq.c > > +++ linux-pm/drivers/cpufreq/acpi-cpufreq.c > > @@ -986,12 +986,12 @@ static int __init acpi_cpufreq_init(void > > { > > int ret; > > > > + if (acpi_disabled) > > + return -ENODEV; > > + > > /* don't keep reloading if cpufreq_driver exists */ > > if (cpufreq_get_current_driver()) > > - return 0; > > - > > - if (acpi_disabled) > > - return 0; > > + return -EEXIST; > > > > pr_debug("acpi_cpufreq_init\n"); > > Even better, > > Acked-by: Viresh Kumar It doesn't lead to any unpleasant side effects on my laptop, so I'm adding it to my queue of fixes for 3.12-rc7. Thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/