Message-ID: <1382713547.2501.12.camel@joe-AO722>
Subject: Re: [PATCH] skd: Replaced custom debug PRINTKs with pr_debug
From: Joe Perches <joe@perches.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Ramprasad Chinthekindi <Ramprasad.Chinthekindi@hgst.com>,
        Akhil Bhansali <Akhil.Bhansali@hgst.com>,
        "jmoyer@redhat.com" <jmoyer@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Amit Phansalkar <Amit.Phansalkar@hgst.com>
Date: Fri, 25 Oct 2013 08:05:47 -0700
In-Reply-To: <20131025112430.GE6285@kernel.dk>
References: <24CA9A5C93173F48A9E3313B866A7C280F344E@MYMBX3.stec-inc.ad>
	 <20131024115304.GW14598@kernel.dk> <1382627375.22433.58.camel@joe-AO722>
	 <20131025112430.GE6285@kernel.dk>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1162
Lines: 33

On Fri, 2013-10-25 at 12:24 +0100, Jens Axboe wrote:
> On Thu, Oct 24 2013, Joe Perches wrote:
> > On Thu, 2013-10-24 at 12:53 +0100, Jens Axboe wrote:
> > > On Thu, Oct 24 2013, Ramprasad Chinthekindi wrote:
> > > > Hi Jens,
> > > > 
> > > > I'm resending the patch to replace custom debug macros with
> > > > pr_debug(). Kindly please review and apply the patch.  Thanking you.
> > > 
> > > Thanks, that's a nice improvement. Applied.
> > 
> > Is it really much of an improvement?
> > 
> > It leaves possible different behavior with
> > skdev->dbg_level/skd_dbg_level set without
> > linkage to a few printks now.
> > 
> > It also doesn't make use of dynamic debug's
> > +f/+l capability to and always emits
> > __func__/__LINE__.
> 
> It's an improvement from a private FOOPRINTK() macro. Feel free to send
> in further improvements.

I already sent what I think appropriate.

https://lkml.org/lkml/2013/10/1/324

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/