Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755043Ab3JYPUI (ORCPT ); Fri, 25 Oct 2013 11:20:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52378 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754905Ab3JYPUH (ORCPT ); Fri, 25 Oct 2013 11:20:07 -0400 Date: Fri, 25 Oct 2013 16:21:46 +0100 From: Greg KH To: Frank Haverkamp Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, cody@linux.vnet.ibm.com, schwidefsky@de.ibm.com, utz.bacher@de.ibm.com, mmarek@suse.cz, jsvogt@de.ibm.com, MIJUNG@de.ibm.com, cascardo@linux.vnet.ibm.com, michael@ibmra.de, Frank Haverkamp Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v3) Message-ID: <20131025152146.GA27323@kroah.com> References: <20131024100942.GA13614@kroah.com> <1382695784-10127-2-git-send-email-haver@linux.vnet.ibm.com> <20131025104212.GA22369@kroah.com> <1382709644.8698.31.camel@oc7383187364.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1382709644.8698.31.camel@oc7383187364.ibm.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 725 Lines: 18 On Fri, Oct 25, 2013 at 04:00:44PM +0200, Frank Haverkamp wrote: > > And why are you doing debug stuff through the ioctl interface? Please > > move that to debugfs if you really want/need that information, it does > > not belong in an ioctl. > > I will look into that. We need that information per card when it fails. People put per-card information in debugfs all the time, look at the USB host controller files in debugfs for an example of how to do this. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/