Date: Fri, 25 Oct 2013 20:29:24 +0500
From: "Zubair Lutfullah :" <zubair.lutfullah@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Samuel Ortiz <sameo@linux.intel.com>, linux-kernel@vger.kernel.org,
        Zubair Lutfullah <zubair.lutfullah@gmail.com>,
        Felipe Balbi <balbi@ti.com>, kishon@ti.com
Subject: Re: [PATCH] mfd: ti_am335x_tscadc: avoid possible deadlock of
 reg_lock
Message-ID: <20131025152922.GA4263@gmail.com>
References: <1382451159-25183-1-git-send-email-bigeasy@linutronix.de>
 <20131022171359.GC2620@lee--X1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131022171359.GC2620@lee--X1>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 942
Lines: 25

On Tue, Oct 22, 2013 at 06:13:59PM +0100, Lee Jones wrote:
> On Tue, 22 Oct 2013, Sebastian Andrzej Siewior wrote:
> 
> > Since the addition of continuous sampling mode and shared irq support,
> > the reg_lock lock can be taken with and without interrupts. This patch
> > uses the *_irq* variant which should be used in order to avaoid a deadlock.
> > 
> > Cc: Zubair Lutfullah <zubair.lutfullah@gmail.com>
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > ---
> >  drivers/mfd/ti_am335x_tscadc.c | 12 ++++++++----
> >  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> Good catch. Applied, thanks.

Had noticed this and forgot. My bad..

Thanks for catching it.

Zubair
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/