Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753478Ab3JYPlo (ORCPT ); Fri, 25 Oct 2013 11:41:44 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:36078 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751559Ab3JYPlm convert rfc822-to-8bit (ORCPT ); Fri, 25 Oct 2013 11:41:42 -0400 Date: Fri, 25 Oct 2013 08:41:34 -0700 From: Stephen Hemminger To: Zhi Yong Wu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Zhi Yong Wu Subject: Re: [PATCH 1/3] vxlan: silence one build warning Message-ID: <20131025084134.6cfa153a@samsung-9> In-Reply-To: <1382687360-27794-1-git-send-email-zwu.kernel@gmail.com> References: <1382687360-27794-1-git-send-email-zwu.kernel@gmail.com> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1500 Lines: 37 On Fri, 25 Oct 2013 15:49:18 +0800 Zhi Yong Wu wrote: > From: Zhi Yong Wu > > drivers/net/vxlan.c: In function ‘vxlan_sock_add’: > drivers/net/vxlan.c:2298:11: warning: ‘sock’ may be used uninitialized in this function [-Wmaybe-uninitialized] > drivers/net/vxlan.c:2275:17: note: ‘sock’ was declared here > LD drivers/net/built-in.o > > Signed-off-by: Zhi Yong Wu > --- > drivers/net/vxlan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c > index 2ef5b62..e15f1af 100644 > --- a/drivers/net/vxlan.c > +++ b/drivers/net/vxlan.c > @@ -2272,7 +2272,7 @@ static struct vxlan_sock *vxlan_socket_create(struct net *net, __be16 port, > { > struct vxlan_net *vn = net_generic(net, vxlan_net_id); > struct vxlan_sock *vs; > - struct socket *sock; > + struct socket *sock = NULL; > struct sock *sk; > int rc = 0; > unsigned int h; This only happens with certain versions of Gcc which have buggy dependency analysis. It doesn't happen with Gcc 4.7, think it only shows up in 4.4. I would rather not fix the warning this way since it risks masking later bugs if this code ever changes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/