Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752662Ab3JYXUV (ORCPT ); Fri, 25 Oct 2013 19:20:21 -0400 Received: from mail-we0-f177.google.com ([74.125.82.177]:55783 "EHLO mail-we0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751684Ab3JYXUU (ORCPT ); Fri, 25 Oct 2013 19:20:20 -0400 From: Grant Likely Subject: Re: [PATCH 2/2] dmaengine: msm_bam_dma: Add device tree binding To: Andy Gross , Vinod Koul Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Dan Williams , David Brown , Bryan Huntsman , Andy Gross In-Reply-To: <1382732643-8184-3-git-send-email-agross@codeaurora.org> References: <1382732643-8184-1-git-send-email-agross@codeaurora.org> <1382732643-8184-3-git-send-email-agross@codeaurora.org> Date: Sat, 26 Oct 2013 00:20:15 +0100 Message-Id: <20131025232015.9082FC403B6@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2831 Lines: 87 On Fri, 25 Oct 2013 15:24:03 -0500, Andy Gross wrote: > Add device tree probe support for the MSM BAM DMA driver. > > Signed-off-by: Andy Gross > --- > .../devicetree/bindings/dma/msm_bam_dma.txt | 49 ++++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/msm_bam_dma.txt > > diff --git a/Documentation/devicetree/bindings/dma/msm_bam_dma.txt b/Documentation/devicetree/bindings/dma/msm_bam_dma.txt > new file mode 100644 > index 0000000..fe3ed8f > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/msm_bam_dma.txt > @@ -0,0 +1,49 @@ > +MSM BAM DMA controller > + > +Required properties: > +- compatible: Should be "qcom,bam" Really should be more specific than this. "qcom,bam" doesn't clarify what SoC this hardware is implemented on. Otherwise the binding looks fine. g. > +- reg: Address range for DMA registers > +- interrupts: single interrupt for this controller > +- #dma-cells: must be <3> > +- clocks: required clock > +- clock-names: name of clock > + > +Example: > + > + dma0: dma@f9984000 = { > + compatible = "qcom,bam"; > + reg = <0xf9984000 0x15000>; > + interrupts = <0 94 0>; > + clocks = <&bam_dma_ahb_cxc>; > + clock-names = "bam_clk"; > + #dma-cells = <3>; > + }; > + > +Client: > +Required properties: > +- dmas: List of dma channel requests > +- dma-names: Names of aforementioned requested channels > + > +Clients must use the format described in the dma.txt file, using a four cell > +specifier for each channel. > + > +The four cells in order are: > + 1. A phandle pointing to the DMA controller > + 2. The channel number > + 3. The execution environment value for this channel. > + 4. Direction of the fixed unidirectional channel > + 0 - Memory to Device > + 1 - Device to Memory > + > +Example: > + serial@f991e000 { > + compatible = "qcom,msm-uart"; > + reg = <0xf991e000 0x1000> > + <0xf9944000 0x19000>; > + interrupts = <0 108 0>; > + clocks = <&blsp1_uart2_apps_cxc>, <&blsp1_ahb_cxc>; > + clock-names = "gsbi_uart_clk", "gsbi_pclk"; > + > + dmas = <&dma0 0 0 1>, <&dma0 1 0 0>; > + dma-names = "rx", "tx"; > + }; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/