Message-ID: <1382776028.22417.174.camel@hastur.hellion.org.uk>
Subject: Re: [Xen-devel] [PATCH] xen/hvc-console: Make it work with HVM
 guests.
From: Ian Campbell <ian.campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: Julien Grall <julien.grall@linaro.org>, <linux-kernel@vger.kernel.org>,
        <xen-devel@lists.xenproject.org>
Date: Sat, 26 Oct 2013 09:27:08 +0100
In-Reply-To: <20131025193812.GA6256@phenom.dumpdata.com>
References: <1380317117-21719-1-git-send-email-konrad.wilk@oracle.com>
	 <5245FD71.3080408@linaro.org> <20130930144513.GM3106@phenom.dumpdata.com>
	 <5251CD98.70807@linaro.org> <20131023161518.GA28413@phenom.dumpdata.com>
	 <526848C1.5030705@linaro.org> <20131024144921.GB29944@phenom.dumpdata.com>
	 <52694B3F.5090008@linaro.org>
	 <1382633034.22417.121.camel@hastur.hellion.org.uk>
	 <20131025193812.GA6256@phenom.dumpdata.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1432
Lines: 45

On Fri, 2013-10-25 at 15:38 -0400, Konrad Rzeszutek Wilk wrote:
> On Thu, Oct 24, 2013 at 05:43:54PM +0100, Ian Campbell wrote:
> > But stepping back how/why is this function called on x86 when not
> > running under Xen? Wouldn't the use have to be using console=hvc or
> > earlyprintk=xen or something -- which strikes me as user error... IOW
> > can we not just nuke the check
> 
> It shouldn't - ever. On x86 it is called from the early PV bootup code.
> 
> I occasionaly use it when developing/debugging and as such want it working
> in HVM even during early bootup.

Does earlyprintk=ttyS0,cough not Just Work for HVM guests? That would
avoid all of this stuff and assuming it works would be preferable IMHO.

Anyway, if not, then given that the xen_cpuid_base case is entirely x86
specific perhaps we can abstract this as something like:

	if (xen_arch_raw_console(str))
		return

	dom0_write_console(...)

Then ARM:
	#define xen_arch_raw_console 0
and x86
	static inline int xen_arch_raw_console(str)
	{
		if (xen_domain())
			return 0;

		/* Do the outb thing */
		return 1;
	}

This would also avoid the need for #ifdef x86 in the main function which
Julien pointed out.

Ian.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/