Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753064Ab3JZRpT (ORCPT ); Sat, 26 Oct 2013 13:45:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20009 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717Ab3JZRpR (ORCPT ); Sat, 26 Oct 2013 13:45:17 -0400 Date: Sat, 26 Oct 2013 19:44:26 +0200 From: Jiri Olsa To: Stephane Eranian Cc: LKML , Peter Zijlstra , "mingo@elte.hu" , "ak@linux.intel.com" , Arnaldo Carvalho de Melo , "Yan, Zheng" , Borislav Petkov Subject: Re: [PATCH v3 1/4] perf: add active_entry list head to struct perf_event Message-ID: <20131026174426.GD1069@krava.brq.redhat.com> References: <1382533085-7166-1-git-send-email-eranian@google.com> <1382533085-7166-2-git-send-email-eranian@google.com> <20131025145625.GB1196@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1976 Lines: 49 On Sat, Oct 26, 2013 at 06:57:37PM +0200, Stephane Eranian wrote: > On Fri, Oct 25, 2013 at 4:56 PM, Jiri Olsa wrote: > > > > On Wed, Oct 23, 2013 at 02:58:02PM +0200, Stephane Eranian wrote: > > > This patch adds a new fields to the struct perf_event. > > > It is intended to be used to chain events which are > > > active (enabled). It helps in the hardware layer > > > for PMU which do not have actual counter restrictions, i.e., > > > free running read-only counters. Active events are chained > > > as opposed to being tracked via the counter they use. > > > > > > Signed-off-by: Stephane Eranian > > > --- > > > include/linux/perf_event.h | 1 + > > > kernel/events/core.c | 1 + > > > 2 files changed, 2 insertions(+) > > > > > > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > > > index 2e069d1..a376384 100644 > > > --- a/include/linux/perf_event.h > > > +++ b/include/linux/perf_event.h > > > @@ -435,6 +435,7 @@ struct perf_event { > > > struct perf_cgroup *cgrp; /* cgroup event is attach to */ > > > int cgrp_defer_enabled; > > > #endif > > > + struct list_head active_entry; > > > > Could this be in union with 'hlist_entry' ? It looks > > as 'same purpose' and 'mutualy exclusive stuff. > > > You're saying that I could use the hlist_entry field because > it is currently only used by the sw events in the generic layer. > But it seems to be a complicated rcu list for the purpose here. nope, I just meant saving little space like: union { struct list_head active_entry; struct hlist_node hlist_entry; } just a nitpick jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/